Add dns resolution logs and handle error correctly#1287
Merged
Conversation
dobrac
added
bug
dobrac
commented
Oct 2, 2025
| // there's no answer, we can't proxy the request | ||
| if err != nil { | ||
| return "", ErrNodeNotFound | ||
| return "", fmt.Errorf("failed to resolve sandbox: %w", err) |
Contributor
Author
There was a problem hiding this comment.
this should be fatal error, not just node not found
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jakubno
requested changes
Oct 2, 2025
| // there's no answer, we can't proxy the request | ||
| if err != nil { | ||
| return "", ErrNodeNotFound | ||
| return "", fmt.Errorf("failed to resolve sandbox: %w", err) |
There was a problem hiding this comment.
Bug: DNS Query Fails Silently, Causing Invalid Proxying
When DNS queries return no answers but no DNS error, the err variable remains nil after retries. This causes the function to return an empty node string with a nil error, incorrectly signaling success. Downstream code may then attempt to proxy to an invalid empty IP.
jakubno
approved these changes
Oct 2, 2025
ValentaTomas
pushed a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dns resolution logs, handle error correctly
Note
Improve DNS resolution error handling and switch to structured logging with sandbox IDs for DNS and not-found cases.
packages/client-proxy/internal/proxy/proxy.go):logger.WithSandboxID(sandboxId); propagate underlying DNS error (fmt.Errorf("failed to resolve sandbox: %w")) instead of returningErrNodeNotFoundon final failure.packages/shared/pkg/proxy/handler.go):logger.WithSandboxID(notFoundErr.SandboxId)in warn and error logs; minor import added for logger.Written by Cursor Bugbot for commit 0d6792a. This will update automatically on new commits. Configure here.